nealrichardson commented on pull request #9725:
URL: https://github.com/apache/arrow/pull/9725#issuecomment-803154692


   Ultimately what I'm looking for is `open_dataset(path, format = "csv", 
column_names = c(..), null_values = c("NA", "null", "."), strings_can_be_null = 
TRUE)` and have all of those args go through to the right place. The average R 
user shouldn't have to call `FileFormat$create()` directly. I think the extra 
args are already passed to `FileFormat$create()` inside the dataset factory 
constructor, so you're right, `csv_file_format_parse_options()` probably just 
needs to be reworked. I'm happy to take that on (or rope @jonkeane or @ianmcook 
into it) if you want to make a followup JIRA, or feel free to push it ahead 
yourself, you've done a great job getting it to here!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to