tustvold commented on PR #6901: URL: https://github.com/apache/arrow-rs/pull/6901#issuecomment-2551818084
The ticket links to https://docs.rs/arrow2/latest/src/arrow2/array/mod.rs.html#111 and states that unchecked slicing was very important. However, this PR is changing a method that has a different signature, in particular it is `&self` and not `&mut self`. The result is that this method is already performing an atomic increment of the reference count, and so the performance gain of adding an unchecked version is not as obvious to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
