agriyakhetarpal commented on code in PR #45072:
URL: https://github.com/apache/arrow/pull/45072#discussion_r1890957382
##########
python/CMakeLists.txt:
##########
@@ -166,8 +166,17 @@ if($ENV{PYODIDE})
# modules (at least under Pyodide it does).
set(Python3_INCLUDE_DIR $ENV{PYTHONINCLUDE})
set(Python3_LIBRARY $ENV{CPYTHONLIB})
- set(Python3_NumPy_INCLUDE_DIR $ENV{NUMPY_LIB}/core/include)
set(Python3_EXECUTABLE)
+ execute_process(COMMAND ${Python3_EXECUTABLE} -c
+ "import numpy; print(numpy.__version__)"
+ OUTPUT_VARIABLE PYODIDE_NUMPY_VERSION
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ string(REGEX MATCH "^([0-9]+)" PYODIDE_NUMPY_MAJOR_VERSION
${PYODIDE_NUMPY_VERSION})
+ if(NUMPY_MAJOR_VERSION GREATER_EQUAL 2)
Review Comment:
```suggestion
if(PYODIDE_NUMPY_MAJOR_VERSION GREATER_EQUAL 2)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
