tustvold commented on PR #6906: URL: https://github.com/apache/arrow-rs/pull/6906#issuecomment-2554338440
> Is this argument to support f64, i64 and decimal here? (and leave out smaller integer and floating point types) I think we should just support f64, i64 for now. This is all that is actually implemented anyway by this PR, we're just doing implicit coercion. > that's exactly what would happen if interval * decimal is not implemented directly. Right, my point is this PR is not implementing `interval * decimal` it is implementing `interval * float64(decimal)` masquerading as `interval * decimal`. Such lossy conversion IMO should be opt-in and explicit. I'd recommend we leave out decimal support for now, and if people want it we can add support as a separate PR (it will be non-trivial). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
