kszucs commented on code in PR #45001: URL: https://github.com/apache/arrow/pull/45001#discussion_r1893035228
########## cpp/src/arrow/compute/kernels/scalar_hash.cc: ########## @@ -0,0 +1,218 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <algorithm> + +#include "arrow/array/array_base.h" +#include "arrow/array/builder_primitive.h" +#include "arrow/compute/kernels/common_internal.h" +#include "arrow/compute/key_hash_internal.h" +#include "arrow/compute/light_array_internal.h" +#include "arrow/compute/util.h" +#include "arrow/result.h" + +namespace arrow { +namespace compute { +namespace internal { + +// Define symbols visible within `arrow::compute::internal` in this file; +// these symbols are not visible outside of this file. +namespace { + +// ------------------------------ +// Kernel implementations +// It is expected that HashArrowType is either UInt32Type or UInt64Type (default) + +template <typename ArrowType, typename Hasher> +struct FastHashScalar { + using c_type = typename ArrowType::c_type; + + static Result<KeyColumnArray> ToColumnArray( + const ArraySpan& array, LightContext* ctx, + const uint8_t* list_values_buffer = nullptr) { + KeyColumnMetadata metadata; + const uint8_t* validity_buffer = nullptr; + const uint8_t* fixed_length_buffer = nullptr; + const uint8_t* var_length_buffer = nullptr; + + if (array.GetBuffer(0) != nullptr) { + validity_buffer = array.GetBuffer(0)->data(); + } + if (array.GetBuffer(1) != nullptr) { + fixed_length_buffer = array.GetBuffer(1)->data(); + } + + auto type = array.type; + auto type_id = type->id(); + if (type_id == Type::NA) { + metadata = KeyColumnMetadata(true, 0, true); + } else if (type_id == Type::BOOL) { + metadata = KeyColumnMetadata(true, 0); + } else if (is_fixed_width(type_id)) { + metadata = KeyColumnMetadata(true, type->bit_width() / 8); + } else if (is_binary_like(type_id)) { + metadata = KeyColumnMetadata(false, sizeof(uint32_t)); + var_length_buffer = array.GetBuffer(2)->data(); + } else if (is_large_binary_like(type_id)) { + metadata = KeyColumnMetadata(false, sizeof(uint64_t)); + var_length_buffer = array.GetBuffer(2)->data(); + } else if (type_id == Type::MAP) { + metadata = KeyColumnMetadata(false, sizeof(uint32_t)); + var_length_buffer = list_values_buffer; + } else if (type_id == Type::LIST) { + metadata = KeyColumnMetadata(false, sizeof(uint32_t)); + var_length_buffer = list_values_buffer; + } else if (type_id == Type::LARGE_LIST) { + metadata = KeyColumnMetadata(false, sizeof(uint64_t)); + var_length_buffer = list_values_buffer; + } else if (type_id == Type::FIXED_SIZE_LIST) { + auto list_type = checked_cast<const FixedSizeListType*>(type); + metadata = KeyColumnMetadata(true, list_type->list_size()); + fixed_length_buffer = list_values_buffer; + } else { + return Status::TypeError("Unsupported column data type ", type->name(), + " used with hash64 compute kernel"); Review Comment: Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
