pitrou commented on PR #45085: URL: https://github.com/apache/arrow/pull/45085#issuecomment-2557186592
Ok, some observations: 1. can you arrange for List benchmarks to be shorter? there are still not enough iterations in these cases IMHO; `kBenchmarkSize` should probably denote the number of leaf values, not the number of top-level rows 2. why is `page_index_size` so much bigger for the List cases, especially List<String> (even with `SizeStatisticsLevel::None`)? this seems unexpected unless I'm missing something? is this case writing much smaller pages perhaps? 3. are the ZSTD benchmarks useful? they are just adding the compression overhead, we don't expect any significant insight about page index write speed there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
