birschick-bq commented on code in PR #2376:
URL: https://github.com/apache/arrow-adbc/pull/2376#discussion_r1894252560
##########
csharp/test/Drivers/Apache/Hive2/HiveServer2ParametersTest.cs:
##########
@@ -34,16 +34,6 @@ internal void TestParametersDataTypeConvParse(string?
dataTypeConversion, DataTy
Assert.Throws(exceptionType, () =>
DataTypeConversionParser.Parse(dataTypeConversion));
}
- [SkippableTheory]
- [MemberData(nameof(GetParametersTlsOptionTestData))]
- internal void TestParametersTlsOptionParse(string? tlsOptions,
HiveServer2TlsOption expected, Type? exceptionType = default)
Review Comment:
Will you add some tests for the options?
* Empty file path
* Invalid file path
* Non-existent file path
* Mixed intentions?
* `uri` with `http` but `ssl` enabled?
* boolean options that are not `true` or `false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
