kou commented on code in PR #45093:
URL: https://github.com/apache/arrow/pull/45093#discussion_r1894532085
##########
cpp/src/parquet/file_reader.cc:
##########
@@ -400,6 +401,21 @@ class SerializedFile : public ParquetFileReader::Contents {
PARQUET_THROW_NOT_OK(cached_source_->Cache(ranges));
}
+ ::arrow::Result<std::vector<::arrow::io::ReadRange>> GetReadRanges(
+ const std::vector<int>& row_groups, const std::vector<int>&
column_indices,
+ int64_t hole_size_limit, int64_t range_size_limit) {
+ std::vector<::arrow::io::ReadRange> ranges;
+ for (int row : row_groups) {
Review Comment:
`row_group` may be better than `row` because "row" and "row_group" are
different in the Parquet context.
```suggestion
for (int row_group : row_groups) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
