nealrichardson commented on issue #45096:
URL: https://github.com/apache/arrow/issues/45096#issuecomment-2558602645

   Filtering out the deprecation warnings, it looks like the actual error is in 
this chunk: 
   
   ```
   
/tmp/Rtmp2lHvYG/file386a7a7398879e/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/concurrency/Mutex.h:47:26:
 error: 'int64_t' has not been declared
      47 |   virtual bool timedlock(int64_t milliseconds) 
const;
         |                          ^~~~~~~
   
/tmp/Rtmp2lHvYG/file386a7a7398879e/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/concurrency/Mutex.h:25:1:
 note: 'int64_t' is defined in header 
'<cstdint>'; this is probably fixable by adding '#include 
<cstdint>'
      24 | #include <thrift/TNonCopyable.h>
     +++ |+#include <cstdint>
      25 | 
   
/tmp/Rtmp2lHvYG/file386a7a7398879e/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/concurrency/Mutex.h:60:29:
 error: 'int64_t' has not been declared
      60 |   Guard(const Mutex& value, int64_t timeout = 0) : 
mutex_(&value) {
         |                             ^~~~~~~
   
/tmp/Rtmp2lHvYG/file386a7a7398879e/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/concurrency/Mutex.h:60:29:
 note: 'int64_t' is defined in header 
'<cstdint>'; this is probably fixable by adding '#include 
<cstdint>'
   ```
   
   `int64_t has not been declared`; `int64_t is defined in header <cstdint>`; 
`this is probably fixable by adding "#include <cstdint>"`
   
   
https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/concurrency/Mutex.h
 has not been modified in 3 years so this has not been addressed upstream. 
Assuming this is legitimate, we should file an issue submit the one-line patch 
upstream, but we'll probably also have to add a patch step to our thrift 
external project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to