kou commented on code in PR #45100:
URL: https://github.com/apache/arrow/pull/45100#discussion_r1895380512
##########
cpp/src/arrow/status.h:
##########
@@ -332,10 +332,7 @@ class ARROW_EXPORT [[nodiscard]] Status : public
util::EqualityComparable<Status
constexpr StatusCode code() const { return ok() ? StatusCode::OK :
state_->code; }
/// \brief Return the specific error message attached to this status.
- const std::string& message() const {
- static const std::string no_message = "";
- return ok() ? no_message : state_->msg;
- }
+ const std::string& message() const;
/// \brief Return the status detail attached to this message.
const std::shared_ptr<StatusDetail>& detail() const {
Review Comment:
Do we need to do the same thing for this too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
