andygrove commented on pull request #9762:
URL: https://github.com/apache/arrow/pull/9762#issuecomment-803620665


   Thanks @returnString and I appreciate the well-written design doc to explain 
the PR. I didn't go through the code in great detail but I like the design. I 
noted a couple of unwraps in the code. It would be good to document why they 
are safe or consider having those methods return `Result` if they are not safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to