paleolimbot commented on code in PR #694:
URL: https://github.com/apache/arrow-nanoarrow/pull/694#discussion_r1898184458
##########
ci/docker/ubuntu.dockerfile:
##########
@@ -20,7 +20,7 @@ ARG NANOARROW_ARCH
FROM --platform=linux/${NANOARROW_ARCH} ubuntu:latest
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
- locales git cmake r-base gnupg curl valgrind gfortran python3-venv
python3-dev doxygen pandoc lcov \
+ locales git cmake r-base gnupg curl valgrind gfortran python3-venv
python3-dev doxygen pandoc gcovr \
Review Comment:
It's the right place! The image this is using in docker-compose.yml is a
multi-platform manifest (to in theory make it easier for anybody to run
locally, M1 or AMD), but the multi-platform upload happens in CI when the image
update is merged to main. If you want to check for sure in CI you could update
docker-compose.yml temporarily to point to the Dockerfile instead of the remote
image (or you can confirm it works locally and we can merge with the failing
CI...I trust you!).
The only way to do this keeping CI passing the whole time would be to update
the image dockerfile, merge, rebuild + upload the images using a manual
workflow-dispatch, then PR the changes to the scripts. Feel free to do it all
in one go, though 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
