cyb70289 commented on a change in pull request #9746:
URL: https://github.com/apache/arrow/pull/9746#discussion_r598498830
##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -83,7 +83,7 @@ function(test_grpc_version DST_VAR DETECT_VERSION TEST_FILE)
try_compile(HAS_GRPC_VERSION ${CMAKE_CURRENT_BINARY_DIR}/try_compile
SOURCES
"${CMAKE_CURRENT_SOURCE_DIR}/try_compile/${TEST_FILE}"
CMAKE_FLAGS
"-DINCLUDE_DIRECTORIES=${CURRENT_INCLUDE_DIRECTORIES}"
- LINK_LIBRARIES gRPC::grpc gRPC::grpc++
+ LINK_LIBRARIES ${GRPC_STATIC_LIBRARY_GRPCPP} gRPC::grpc
gRPC::gpr gRPC::upb gRPC::address_sorting ${ABSL_LIBRARIES} ${ABSL_LIBRARIES}
-pthread
Review comment:
> Note that the example for 2. improves `INTERFACE_LINK_LIBRARIES` for
bundled gRPC but we should do it for system gRPC in
`cpp/cmake_modules/FindgRPCAlt.cmake`.
I didn't changed `FindgRPCAlt.cmake`. Looks it works correctly for
pre-installed gRPC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
