Re: [PR] [Parquet] Add projection utility functions [arrow-rs]

Fri, 03 Jan 2025 03:03:45 -0800 


alamb commented on code in PR #6931:
URL: https://github.com/apache/arrow-rs/pull/6931#discussion_r1901679100


##########
parquet/src/arrow/mod.rs:
##########
@@ -281,6 +281,41 @@ impl ProjectionMask {
     pub fn leaf_included(&self, leaf_idx: usize) -> bool {
         self.mask.as_ref().map(|m| m[leaf_idx]).unwrap_or(true)
     }
+
+    /// Union two projection masks
+    ///
+    /// Example:
+    /// mask1 = [true, false, true]
+    /// mask2 = [false, true, true]
+    /// union(mask1, mask2) = [true, true, true]

Review Comment:
   The rendered docs look.a bit off:
   ![Screenshot 2025-01-03 at 5 58 49 
AM](https://github.com/user-attachments/assets/08ee9fe6-757c-4577-9f13-841e35bbe614)
   
   I pushed a commit to make them a bit nicer
   
   ```suggestion
       /// Example:
       /// mask1 = [true, false, true]
       /// mask2 = [false, true, true]
       /// union(mask1, mask2) = [true, true, true]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to