raulcd commented on code in PR #45141: URL: https://github.com/apache/arrow/pull/45141#discussion_r1901680592
########## docs/source/developers/release.rst: ########## @@ -67,7 +70,8 @@ generated properly. Before creating a Release Candidate =================================== -Ensure local tags are removed, gpg-agent is set and JIRA tickets are correctly assigned. +Ensure local tags are removed, gpg-agent is set and GitHub issues and pull +requests are correctly assigned. Review Comment: same as above, PRs at the moment are not required to be assigned. I agree that this could be modified in the future as we might want to change the workflow, i.e. there has been discussions in the past of whether we require an issue always and we could just create PRs but at the moment, the PR milestone is not used on the scripts. ########## docs/source/developers/release.rst: ########## @@ -36,8 +39,8 @@ Preparing for the release ========================= Before creating a source release, the Release Manager must ensure that any -resolved JIRAs have the appropriate Fix Version set so that the changelog is -generated properly. +resolved GitHub issues and any MINOR pull requests have the appropriate Review Comment: MINOR pull requests don't require the milestone for the changelog to be generated correctly. The changelog goes over the issues on GH to validate no issues are tagged but missing from commits but for minor only the commits on the branch are required. ########## docs/source/developers/release.rst: ########## @@ -36,8 +39,8 @@ Preparing for the release ========================= Before creating a source release, the Release Manager must ensure that any -resolved JIRAs have the appropriate Fix Version set so that the changelog is -generated properly. +resolved GitHub issues and any MINOR pull requests have the appropriate +milestone set so that the changelog is generated properly. Review Comment: MINOR issues should not be cherry-picked for a release. If we have done the feature freeze and an issue is required for the release, the issue deserves to be non-MINOR. We should not encourage the use of minor for issues that have to be cherry-picked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
