jorisvandenbossche commented on code in PR #44195:
URL: https://github.com/apache/arrow/pull/44195#discussion_r1901847748
##########
python/pyarrow/src/arrow/python/arrow_to_pandas.cc:
##########
@@ -2523,7 +2523,8 @@ Status ConvertCategoricals(const PandasOptions& options,
ChunkedArrayVector* arr
}
if (options.strings_to_categorical) {
for (int i = 0; i < static_cast<int>(arrays->size()); i++) {
- if (is_base_binary_like((*arrays)[i]->type()->id())) {
+ if (is_base_binary_like((*arrays)[i]->type()->id()) ||
Review Comment:
Somewhat tangential yes, as in that it is also a useful change to do
regardless of the other changes here. I am also not entirely sure there is a
very specific test for this.
Happy to move out to a separate PR, although I then would like both to get
merged for 19.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
