pitrou commented on code in PR #35323: URL: https://github.com/apache/arrow/pull/35323#discussion_r1901844263
########## ci/scripts/python_wheel_windows_build.bat: ########## @@ -121,7 +127,24 @@ set ARROW_HOME=C:\arrow-dist set CMAKE_PREFIX_PATH=C:\arrow-dist pushd C:\arrow\python -@REM bundle the msvc runtime -cp "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Redist\MSVC\14.28.29325\x64\Microsoft.VC142.CRT\msvcp140.dll" pyarrow\ + +@REM Bundle the C++ runtime +cp C:\Windows\System32\msvcp140.dll pyarrow\ + +@REM Build wheel python setup.py bdist_wheel || exit /B 1 + +@REM Repair the wheel with delvewheel +@REM +@REM Since we bundled the Arrow C++ libraries ourselves, we only need to +@REM mangle msvcp140.dll so as to avoid ABI issues when msvcp140.dll is +@REM required by multiple Python libraries in the same process. Review Comment: ```suggestion @REM required by multiple Python libraries in the same process. @REM @REM For now this requires a custom version of delvewheel: @REM https://github.com/adang1345/delvewheel/pull/59 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
