alamb commented on code in PR #6905:
URL: https://github.com/apache/arrow-rs/pull/6905#discussion_r1903093540
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -1284,7 +1284,7 @@ mod tests {
assert_eq!("53.002666", lat.value_as_string(1));
assert_eq!("52.412811", lat.value_as_string(2));
assert_eq!("51.481583", lat.value_as_string(3));
- assert_eq!("12.123456", lat.value_as_string(4));
+ assert_eq!("12.123457", lat.value_as_string(4));
Review Comment:
I personally wouldn't characterize this a breaking change, though I can see
how others might.
In my opinion, adding a parameter to choose between the behaviors would be
the safest thing (aka a field to `CastOptions` that defaults to the old,
rounding, behavior) for
https://docs.rs/arrow/latest/arrow/compute/kernels/cast/fn.cast_with_options.html
Maybe @liukun4515 who added much of the initial decimal support in arrow-rs
has time to offer historical perspective on rounding vs truncation during
casting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
