jorisvandenbossche opened a new pull request, #45176:
URL: https://github.com/apache/arrow/pull/45176

   ### Rationale for this change
   
   Currently this keyword works for string or large string:
   
   ```python
   >>> table = pa.table({"col": pa.array(["a", "b", "a"], pa.string())})
   >>> table.to_pandas(strings_to_categorical=True).dtypes
   col    category
   dtype: object
   >>> table = pa.table({"col": pa.array(["a", "b", "a"], pa.large_string())})
   >>> table.to_pandas(strings_to_categorical=True).dtypes
   col    category
   dtype: object
   ```
   
   but not for string view:
   
   ```python
   >>> table = pa.table({"col": pa.array(["a", "b", "a"], pa.string_view())})
   >>> table.to_pandas(strings_to_categorical=True).dtypes
   col    object
   dtype: object
   ```
   
   For consistency we should make that keyword check for string view columns as 
well, I think
   
   From https://github.com/apache/arrow/pull/44195/files#r1901831460
   
   ### Are these changes tested?
   
   Yes
   
   ### Are there any user-facing changes?
   
   Yes, when using the `strings_to_categorical=True` keyword and having a 
string_view type, this column will now be converted to a pandas Categorical
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to