CurtHagenlocher commented on code in PR #2409:
URL: https://github.com/apache/arrow-adbc/pull/2409#discussion_r1903634384
##########
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriverExporter.cs:
##########
@@ -127,12 +127,13 @@ public unsafe static AdbcStatusCode AdbcDriverInit(int
version, CAdbcDriver* nat
nativeDriver->StatementBindStream = StatementBindStreamPtr;
nativeDriver->StatementExecuteQuery = StatementExecuteQueryPtr;
nativeDriver->StatementExecutePartitions =
StatementExecutePartitionsPtr;
- nativeDriver->StatementGetParameterSchema =
StatementGetParameterSchemaPtr;
+ nativeDriver->StatementExecuteSchema = StatementExecuteSchemaPtr;
nativeDriver->StatementNew = StatementNewPtr;
nativeDriver->StatementPrepare = StatementPreparePtr;
nativeDriver->StatementRelease = StatementReleasePtr;
nativeDriver->StatementSetSqlQuery = StatementSetSqlQueryPtr;
nativeDriver->StatementSetSubstraitPlan =
StatementSetSubstraitPlanPtr;
+ nativeDriver->StatementGetParameterSchema =
StatementGetParameterSchemaPtr;
Review Comment:
These fields are deliberately initialized in the order that they are
declared in `adbc.h` to make it easy to compare the two. If you look at that
definition, you'll see that `StatementGetParameterSchema` does indeed come
immediately after `StatementExecutePartitions` and that
`StatementExecuteSchema` doesn't come until the 1.1 section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
