pitrou commented on issue #44615: URL: https://github.com/apache/arrow/issues/44615#issuecomment-2573362009
@rtbs-dev If you'd like to contribute to Arrow, you can search for the `good-first-issue` label in the issues: https://github.com/apache/arrow/issues?q=is%3Aopen+is%3Aissue+label%3Agood-first-issue As for the `extract_regex` function, most of the excitement happens here: https://github.com/apache/arrow/blob/a931affa1766be1f98979228ca6ab124aa7f793c/cpp/src/arrow/compute/kernels/scalar_string_ascii.cc#L2180-L2350 As you can see there's a `ExtractRegexData` that gets initialized from the function options (and also helps computing the output type), a base helper class `ExtractRegexBase` for execution, and a `ExtractRegex` derived class that's templated on the input string type (e.g. binary() vs. utf8()). Finally I agree that a new function `extract_regex_spans` would be better than adding options to `extract_regex`. The new function can easily reuse/expand the facilities above, however. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
