pitrou commented on code in PR #45189:
URL: https://github.com/apache/arrow/pull/45189#discussion_r1906665168
##########
python/pyarrow/_parquet.pxd:
##########
@@ -484,11 +484,9 @@ cdef extern from "parquet/arrow/reader.h" namespace
"parquet::arrow" nogil:
const vector[int]& column_indices,
shared_ptr[CTable]* out)
- CStatus GetRecordBatchReader(const vector[int]& row_group_indices,
- const vector[int]& column_indices,
- unique_ptr[CRecordBatchReader]* out)
- CStatus GetRecordBatchReader(const vector[int]& row_group_indices,
- unique_ptr[CRecordBatchReader]* out)
+ CResult[shared_ptr[CRecordBatchReader]] GetRecordBatchReader(const
vector[int]& row_group_indices,
+ const
vector[int]& column_indices)
+ CResult[shared_ptr[CRecordBatchReader]] GetRecordBatchReader(const
vector[int]& row_group_indices)
Review Comment:
`GetRecordBatchReader` on the C++ side returns a `unique_ptr`, not a
`shared_ptr`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
