jonkeane commented on code in PR #44989: URL: https://github.com/apache/arrow/pull/44989#discussion_r1907219456
########## .env: ########## @@ -54,6 +54,7 @@ UBUNTU=22.04 # Default versions for various dependencies CLANG_TOOLS=14 +CMAKE_VERSION=3.25.0 Review Comment: Agreed with Neal, this would be fine to revert, and was a redherring in our testing. If it works in our CI that's ok. We might want to add a note (not totally sure where, though honestly) that the `CMAKE` env var is _sometimes_ used for version number and _sometimes_ used for a path to the executable https://github.com/apache/arrow/blob/4ede48c89b8ec80bbd1895357f272c5fb61bc9b6/r/tools/nixlibs.R#L695-L700 and https://github.com/apache/arrow/blob/4ede48c89b8ec80bbd1895357f272c5fb61bc9b6/r/inst/build_arrow_static.sh#L33 are examples. I don't think we ever in our CI use the path version of this, but we do support it in case users configure it in that way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
