alexwilcoxson-rel opened a new pull request, #6954:
URL: https://github.com/apache/arrow-rs/pull/6954
…with zero (#6805)
* fix: Encoding of List offsets was incorrect when slice offsets begin with
zero
When encoding offsets the code had an optimization to reuse the offsets if
the first offset was zero assuming the slice already pointed
to first element. But the offset can also be zero if all previous lists
were empty. When this occured it mold make all lists in the
slice as empty, even if they shouldn't be.
* Use Buffer::from_slice_ref which will be faster as it doesn't iterate
through the slice.
* Avoid copying
* Explicitly reference std::mem::size_of
(cherry picked from commit fe7e71ac23466a2a4dc142d73e5ec2008ca3e222)
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
