icexelloss commented on issue #45190: URL: https://github.com/apache/arrow/issues/45190#issuecomment-2578441799
This looks good to me. One thing I might add is that there are a few different favors of percentile rank, e.g. (1) scale to 1/n+1, 2/n+1, …, n/n+1 (0-1 exclusive) (2) scale to 0/n-1, 1/n-1, … n-1/n-1 (0-1 inclusive) So might be useful to expose the option for the user to choose which one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org