zanmato1984 commented on PR #45210: URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581974215
Thank you so much for the confirmation. > In general, we should use `sanitizers-*` -> `features-*` -> `base-*` order to avoid this problem, right? Yes, that seems to be the general rule for inheritance. > I think that `0-sanitizer-*`, `1-features-*`, `base-*` is better but it's not a strong opinion. If you like non-alphabetical order, I'm OK with it. I personally think introducing number prefix could be a bit overkill. And hope that the repeating occurrences of `sanitizers-*` -> `features-*` -> `base-*` pattern will hint people enough to realize that this is the intended order (though we can't really mandate it). Once we upgrade to cmake that is new enough to support comments, then we can add some description then. I'll rework the PR, keeping the non-related refinement, and reducing the ordering stuff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
