kou commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1910084061
##########
cpp/CMakePresets.json:
##########
@@ -274,329 +263,325 @@
{
"name": "ninja-debug-basic",
"inherits": [
- "base-debug",
- "features-basic"
+ "features-basic",
+ "base-debug"
],
"displayName": "Debug build with tests and reduced dependencies",
"cacheVariables": {}
},
{
"name": "ninja-debug",
"inherits": [
- "base-debug",
- "features-main"
+ "features-main",
+ "base-debug"
],
"displayName": "Debug build with tests and more optional components",
"cacheVariables": {}
},
{
"name": "ninja-debug-cuda",
"inherits": [
- "base-debug",
- "features-cuda"
+ "features-cuda",
+ "base-debug"
],
"displayName": "Debug build with tests and CUDA integration",
"cacheVariables": {}
},
{
"name": "ninja-debug-filesystems",
"inherits": [
- "base-debug",
- "features-filesystems"
+ "features-filesystems",
+ "base-debug"
],
"displayName": "Debug build with tests and filesystems",
"cacheVariables": {}
},
{
"name": "ninja-debug-flight",
"inherits": [
- "base-debug",
- "features-flight"
+ "features-flight",
+ "base-debug"
],
"displayName": "Debug build with tests and Flight",
"cacheVariables": {}
},
{
"name": "ninja-debug-flight-sql",
"inherits": [
- "base-debug",
- "features-flight-sql"
+ "features-flight-sql",
+ "base-debug"
],
"displayName": "Debug build with tests and Flight SQL",
"cacheVariables": {}
},
{
"name": "ninja-debug-gandiva",
"inherits": [
- "base-debug",
- "features-gandiva"
+ "features-gandiva",
+ "base-debug"
],
"displayName": "Debug build with tests and Gandiva",
"cacheVariables": {}
},
{
"name": "ninja-debug-python-minimal",
"inherits": [
- "base-debug",
- "features-python-minimal"
+ "features-python-minimal",
+ "base-debug"
],
"displayName": "Debug build for PyArrow with minimal features",
"cacheVariables": {}
},
{
"name": "ninja-debug-python",
"inherits": [
- "base-debug",
- "features-python"
+ "features-python",
+ "base-debug"
],
"displayName": "Debug build for PyArrow with common features (for
backward compatibility)",
"cacheVariables": {}
},
{
"name": "ninja-debug-python-maximal",
"inherits": [
- "base-debug",
- "features-python-maximal"
+ "features-python-maximal",
+ "base-debug"
],
"displayName": "Debug build for PyArrow with everything enabled",
"cacheVariables": {}
},
{
"name": "ninja-debug-maximal",
"inherits": [
- "base-debug",
- "features-maximal"
+ "features-maximal",
+ "base-debug"
],
"displayName": "Debug build with everything enabled (except benchmarks)",
"cacheVariables": {}
},
+ {
+ "name": "ninja-debug-emscripten",
+ "inherits": [
+ "features-emscripten",
+ "base-debug"
+ ],
+ "displayName": "Debug build which builds an Emscripten library",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-valgrind-minimal",
+ "inherits": [
+ "features-valgrind",
+ "ninja-debug-minimal"
+ ],
+ "displayName": "Debug build for Valgrind without anything enabled",
+ "cacheVariables": {}
+ },
{
"name": "ninja-debug-valgrind-basic",
"inherits": [
- "base-debug",
- "features-basic",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-basic"
],
- "displayName": "Debug build for Valgrind with reduced dependencies",
+ "displayName": "Debug build for Valgrind with tests and reduced
dependencies",
"cacheVariables": {}
},
{
"name": "ninja-debug-valgrind",
"inherits": [
- "base-debug",
- "features-main",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug"
],
- "displayName": "Debug build for Valgrind with more optional components",
+ "displayName": "Debug build for Valgrind with tests and more optional
components",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-minimal",
+ "name": "ninja-debug-valgrind-maximal",
"inherits": [
- "base-debug",
- "features-minimal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-maximal"
],
- "displayName": "Debug build for Valgrind without anything enabled",
+ "displayName": "Debug build for Valgrind with tests and everything
enabled",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-maximal",
+ "name": "ninja-debug-asan",
"inherits": [
- "base-debug",
- "features-maximal",
- "features-valgrind"
+ "sanitizer-asan",
+ "ninja-debug"
],
- "displayName": "Debug build for Valgrind with everything enabled",
+ "displayName": "Debug build for ASAN with tests and more optional
components",
"cacheVariables": {}
},
{
- "name": "ninja-release-minimal",
+ "name": "ninja-debug-tsan",
"inherits": [
- "base-release",
- "features-minimal"
+ "sanitizer-tsan",
+ "ninja-debug"
],
- "displayName": "Release build without anything enabled",
+ "displayName": "Debug build for TSAN with tests and more optional
components",
"cacheVariables": {}
},
{
- "name": "ninja-release-basic",
+ "name": "ninja-debug-ubsan",
"inherits": [
- "base-release",
- "features-basic"
+ "sanitizer-ubsan",
+ "ninja-debug"
],
- "displayName": "Release build with reduced dependencies",
+ "displayName": "Debug build for UBSAN with tests and more optional
components",
"cacheVariables": {}
},
{
- "name": "ninja-release",
+ "name": "fuzzing",
"inherits": [
- "base-release",
- "features-main"
+ "base",
+ "sanitizer-asan",
+ "sanitizer-ubsan"
Review Comment:
```suggestion
"sanitizer-asan",
"sanitizer-ubsan",
"base"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
