alamb commented on code in PR #6958: URL: https://github.com/apache/arrow-rs/pull/6958#discussion_r1911087682
########## README.md: ########## @@ -90,6 +90,14 @@ Planned Release Schedule | Dec 2024 | `0.11.2` | Minor, NO breaking API changes | | Feb 2025 | `0.12.0` | Major, potentially breaking API changes | +### Guidelines for `panic` vs `Result` + +In general, use panics for bad states that are unreachable, unrecoverable or harmful. +For those caused by invalid user input, however, we prefer to report that invalidity +gracefully as an error result instead of panicking. Note that it still makes sense +to have some panic/assert statements, given that the invalidity of user input is +examined and reported as errors first. Review Comment: ```suggestion gracefully as an error result instead of panicking. In general, invalid input should result in an `Error` as soon as possible. It *is* ok for code paths after validation to assume validation has already occurred and and panic if not. See [this ticket] for more nuances. [this ticket]: https://github.com/apache/arrow-rs/issues/6737 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
