alamb commented on PR #6960:
URL: https://github.com/apache/arrow-rs/pull/6960#issuecomment-2583966848
I agree with @tustvold that unless there is a problem we are fixing we
shouldn't make this change
I double checked that arrow-json runs fine without the default features
enabled
```shell
(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/arrow-rs$ cargo check
--no-default-features -p arrow-json
Compiling libc v0.2.169
Checking arrow-schema v54.0.0
(/Users/andrewlamb/Software/arrow-rs/arrow-schema)
Checking zerocopy v0.7.35
Checking once_cell v1.20.2
Compiling serde v1.0.217
Compiling serde_json v1.0.134
Checking indexmap v2.7.0
Checking arrow-buffer v54.0.0
(/Users/andrewlamb/Software/arrow-rs/arrow-buffer)
Checking arrow-data v54.0.0
(/Users/andrewlamb/Software/arrow-rs/arrow-data)
Checking getrandom v0.2.15
Checking ahash v0.8.11
Checking arrow-array v54.0.0
(/Users/andrewlamb/Software/arrow-rs/arrow-array)
Checking arrow-select v54.0.0
(/Users/andrewlamb/Software/arrow-rs/arrow-select)
Checking arrow-cast v54.0.0
(/Users/andrewlamb/Software/arrow-rs/arrow-cast)
Checking arrow-json v54.0.0
(/Users/andrewlamb/Software/arrow-rs/arrow-json)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.38s
```
I also verified that a new cargo project that only arrow-json without
default features works fine too:
```toml
[package]
name = "test_arrow_json"
version = "0.1.0"
edition = "2021"
[dependencies]
arrow-json = { version = "54.0.0", default-features = false }
```
```
/Users/andrewlamb/.cargo/bin/cargo run --color=always --package
test_arrow_json --bin test_arrow_json --profile dev
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.02s
Running `target/debug/test_arrow_json`
Hello, world!
```
Full project is here:
[test_arrow_json.tar.gz](https://github.com/user-attachments/files/18381934/test_arrow_json.tar.gz)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
