kou commented on code in PR #45222:
URL: https://github.com/apache/arrow/pull/45222#discussion_r1911781090


##########
dev/tasks/macros.jinja:
##########
@@ -182,15 +182,19 @@ env:
 {% endmacro %}
 
 {%- macro github_upload_wheel_scientific_python(pattern) -%}
-  {%- if arrow.is_default_branch() -%}
   - name: Upload wheel to Anaconda scientific-python
     shell: bash
     run: |
+      # check if completion actually expands to wheel files
+      # to prevent empty dirs from failing silently
+      if ! test -n "$(find . -wholename '{{ pattern }}' -print -quit)"; then

Review Comment:
   We may be able to simplify this:
   
   ```suggestion
         if [ "$(echo {{ pattern }})" = "{{ pattern }}" ]; then
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to