davidhcoe commented on code in PR #2431:
URL: https://github.com/apache/arrow-adbc/pull/2431#discussion_r1911796161
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -752,10 +757,19 @@ private string PatternToRegEx(string? pattern)
return builder.ToString();
}
- private string ToTypeName(string type)
+ private string ToTypeName(string type, out string suffix)
{
- int index = Math.Min(type.IndexOf("("), type.IndexOf("<"));
+ suffix = string.Empty;
+
+ int index = type.IndexOf("(");
+ if (index == -1)
+ index = type.IndexOf("<");
Review Comment:
That's because the first one looks for Array<type>, Struct<x,y,z>,
NUMERIC(n, y), etc but the ParsePrecisionAndScale only cares about the
numeric-based values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
