alamb commented on PR #6966: URL: https://github.com/apache/arrow-rs/pull/6966#issuecomment-2585351322
> Just some minor nits, the use of an unsafe flag does have the unfortunate property of disconnecting the point of unsafe ""entry" from its "usage", but in this case it is probably fine, and this is really an issue with unsafe in general. Yes I agree this is unforutnate. I will add some comments to make this as explicit as I can (namely that setting the flag to true incorrectly results in undefined behavior) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
