lidavidm commented on issue #45120:
URL: https://github.com/apache/arrow/issues/45120#issuecomment-2586016902
```
#ifdef GRPC_ENABLE_ASYNC
// TODO(https://github.com/apache/arrow/issues/30949): if there are async
// RPCs running when the client is stopped, then when they go to use the
// garbage bin, they'll instead synchronously dispose of resources from
// the callback thread, and will likely crash. We could instead cancel
// them first and wait for completion before stopping the thread, but
// tracking all of the RPCs may be unacceptable overhead for clients that
// are making many small concurrent RPC calls, so it remains to be seen
// whether there's a pressing need for this.
garbage_bin_->Stop();
#endif
```
I'd rather just disable the test (upstream), since it's deliberately
misusing the library to see how well we protect the user from gRPC. But I've
come around to thinking this is misguided (wrapping gRPC or trying to make it
so that the user isn't aware of gRPC means the user can't debug/control things
when they want to be able to and it just adds to the maintenance burden).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
