mapleFU commented on code in PR #44043:
URL: https://github.com/apache/arrow/pull/44043#discussion_r1914359812


##########
cpp/src/parquet/file_reader.cc:
##########
@@ -266,13 +266,17 @@ class SerializedRowGroup : public 
RowGroupReader::Contents {
     ARROW_DCHECK_NE(meta_decryptor, nullptr);
     ARROW_DCHECK_NE(data_decryptor, nullptr);
 
-    constexpr auto kEncryptedRowGroupsLimit = 32767;
-    if (i > kEncryptedRowGroupsLimit) {
+    constexpr auto kEncryptedOrdinalLimit = 32767;
+    if (ARROW_PREDICT_FALSE(row_group_ordinal_ > kEncryptedOrdinalLimit)) {

Review Comment:
   Do you mean when contructing `ColumnChunkMetaData::ColumnChunkMetaDataImpl` 
? What if the `ENCRYPTION_WITH_COLUMN_KEY` is not set but this is being 
encrypted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to