zanmato1984 commented on code in PR #45255:
URL: https://github.com/apache/arrow/pull/45255#discussion_r1914768701
##########
cpp/src/arrow/acero/hash_join_node_test.cc:
##########
@@ -3370,8 +3370,10 @@ TEST(HashJoin,
LARGE_MEMORY_TEST(BuildSideOver4GBVarLength)) {
constexpr int value_no_match_length_min = 128;
constexpr int value_no_match_length_max = 129;
constexpr int value_match_length = 130;
+ // The value "DDD..." will be hashed to the partition over 4GB of the hash
table.
Review Comment:
Note this really depends on the hash algorithm which is opaque, but this as
well is the best I can do so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
