assignUser commented on code in PR #45261:
URL: https://github.com/apache/arrow/pull/45261#discussion_r1915727576
##########
r/src/safe-call-into-r-impl.cpp:
##########
@@ -46,11 +46,7 @@ bool SetEnableSignalStopSource(bool enabled) {
// [[arrow::export]]
bool CanRunWithCapturedR() {
-#if defined(HAS_UNWIND_PROTECT)
return MainRThread::GetInstance().Executor() == nullptr;
-#else
- return false;
-#endif
Review Comment:
ah, the header explains it, I'll update the comment but from how I read it
we still need to check for the executor
>// Unwind protection was added in R 3.5 and some calls here use it
// and crash R in older versions (ARROW-16201). Implementation provided
// in safe-call-into-r-impl.cpp so that we can skip some tests
// when this feature is not provided. This also checks that there
// is not already an event loop registered (via MainRThread::Executor()),
// because only one of these can exist at any given time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
