kou commented on code in PR #517:
URL: https://github.com/apache/arrow-java/pull/517#discussion_r1915813912
##########
.github/workflows/rc.yml:
##########
@@ -70,15 +70,269 @@ jobs:
- name: Audit
run: |
dev/release/run_rat.sh "${TAR_GZ}"
- - uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b
# v4.5.0
+ - name: Upload source archive
+ uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
# v4.6.0
with:
- name: archive
+ name: release-source
path: |
apache-arrow-java-*
+ jni-ubuntu:
+ name: JNI ${{ matrix.platform.runs_on }} ${{ matrix.platform.arch }}
+ runs-on: ${{ matrix.platform.runs_on }}
+ needs:
+ - source
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - runs_on: ubuntu-latest
+ arch: "x86_64"
+ archery_arch: "amd64"
+ env:
+ # architecture name used for archery build
+ ARCH: ${{ matrix.platform.archery_arch }}
+ DOCKER_VOLUME_PREFIX: .docker/
+ permissions:
+ contents: read
+ packages: write
+ steps:
+ - name: Download source archive
+ uses:
actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+ with:
+ name: release-source
+ - name: Extract Download the latest Apache Arrow C++
+ run: |
+ tar -xf apache-arrow-java-*.tar.gz --strip-components=1
+ - name: Download the latest Apache Arrow C++
+ run: |
+ ci/scripts/download_cpp.sh
Review Comment:
We may want to use the main branch instead of related Apache Arrow C++ on
daily run. But it's out-of-scope in this PR.
##########
.github/workflows/rc.yml:
##########
@@ -70,15 +70,269 @@ jobs:
- name: Audit
run: |
dev/release/run_rat.sh "${TAR_GZ}"
- - uses: actions/upload-artifact@6f51ac03b9356f520e9adb1b1b7802705f340c2b
# v4.5.0
+ - name: Upload source archive
+ uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
# v4.6.0
with:
- name: archive
+ name: release-source
path: |
apache-arrow-java-*
+ jni-ubuntu:
+ name: JNI ${{ matrix.platform.runs_on }} ${{ matrix.platform.arch }}
+ runs-on: ${{ matrix.platform.runs_on }}
+ needs:
+ - source
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - runs_on: ubuntu-latest
+ arch: "x86_64"
+ archery_arch: "amd64"
+ env:
+ # architecture name used for archery build
+ ARCH: ${{ matrix.platform.archery_arch }}
+ DOCKER_VOLUME_PREFIX: .docker/
+ permissions:
+ contents: read
+ packages: write
+ steps:
+ - name: Download source archive
+ uses:
actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+ with:
+ name: release-source
+ - name: Extract Download the latest Apache Arrow C++
+ run: |
+ tar -xf apache-arrow-java-*.tar.gz --strip-components=1
+ - name: Download the latest Apache Arrow C++
+ run: |
+ ci/scripts/download_cpp.sh
+ - name: Checkout apache/arrow-testing
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ with:
+ repository: apache/arrow-testing
+ path: arrow/testing
+ - name: Checkout apache/parquet-testing
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ with:
+ repository: apache/parquet-testing
+ path: arrow/cpp/submodules/parquet-testing
+ - uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #
v3.3.0
+ with:
+ registry: ghcr.io
+ username: ${{ github.actor }}
+ password: ${{ secrets.GITHUB_TOKEN }}
+ - name: Cache
+ uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
+ with:
+ path: .docker
+ key: jni-linux-${{ matrix.platform.arch }}-${{
hashFiles('arrow/cpp/**') }}
+ restore-keys: jni-linux-${{ matrix.platform.arch }}-
+ - name: Build C++ libraries
+ run: |
+ docker compose run vcpkg-jni
+ - name: Push Docker image
+ if: success() && github.event_name == 'push' && github.repository ==
'apache/arrow-java' && github.ref_name == 'main'
+ run: |
+ docker compose push vcpkg-jni
+ - name: Compress into single artifact to keep directory structure
+ run: tar -cvzf jni-linux-${{ matrix.platform.arch }}.tar.gz jni/
+ - name: Upload artifacts
+ uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08
# v4.6.0
+ with:
+ name: jni-linux-${{ matrix.platform.arch }}
+ path: jni-linux-${{ matrix.platform.arch }}.tar.gz
+ jni-macos:
+ name: JNI ${{ matrix.platform.runs_on }} ${{ matrix.platform.arch }}
+ runs-on: ${{ matrix.platform.runs_on }}
+ needs:
+ - source
+ strategy:
+ fail-fast: false
+ matrix:
+ platform:
+ - { runs_on: macos-13, arch: "x86_64"}
+ - { runs_on: macos-14, arch: "aarch_64" }
+ env:
+ MACOSX_DEPLOYMENT_TARGET: "14.0"
+ steps:
+ - name: Download source archive
+ uses:
actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+ with:
+ name: release-source
+ - name: Extract Download the latest Apache Arrow C++
+ run: |
+ tar -xf apache-arrow-java-*.tar.gz --strip-components=1
+ # We need 19.0.0 for latest Boost support
Review Comment:
apache/arrow#45053
##########
.github/workflows/rc.yml:
##########
@@ -105,37 +357,40 @@ jobs:
else
rc=$(date +%Y%m%d)
fi
- VERIFY_DEFAULT=0 \
- VERIFY_SOURCE=1 \
- dev/release/verify_rc.sh "${version}" "${rc}"
+ tar -xf ${tar_gz}
+ export VERIFY_DEFAULT=0
+ export VERIFY_BINARY=1
+ export VERIFY_SOURCE=1
+ cd apache-arrow-java-*
+ mv ../${tar_gz} ./
+ mv ../release-binaries binaries
+ dev/release/verify_rc.sh "${version}" "${rc}"
upload:
name: Upload
- if: github.ref_type == 'tag'
+ # if: github.ref_type == 'tag'
needs:
- verify
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- - name: Checkout
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
- with:
- submodules: recursive
- - uses:
actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+ - name: Download release artifacts
+ uses:
actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
with:
- name: archive
+ pattern: release-*
+ path: artifacts
- name: Upload
run: |
# GH-499: How to create release notes?
version=${GITHUB_REF_NAME%-rc*}
version=${version#v}
rc=${GITHUB_REF_NAME#*-rc}
- gh release create ${GITHUB_REF_NAME} \
+ echo gh release create ${GITHUB_REF_NAME} \
Review Comment:
I'll revert this after I confirmed that this job works.
##########
.github/workflows/rc.yml:
##########
@@ -105,37 +357,40 @@ jobs:
else
rc=$(date +%Y%m%d)
fi
- VERIFY_DEFAULT=0 \
- VERIFY_SOURCE=1 \
- dev/release/verify_rc.sh "${version}" "${rc}"
+ tar -xf ${tar_gz}
+ export VERIFY_DEFAULT=0
+ export VERIFY_BINARY=1
+ export VERIFY_SOURCE=1
+ cd apache-arrow-java-*
+ mv ../${tar_gz} ./
+ mv ../release-binaries binaries
+ dev/release/verify_rc.sh "${version}" "${rc}"
upload:
name: Upload
- if: github.ref_type == 'tag'
+ # if: github.ref_type == 'tag'
Review Comment:
I'll revert this after I confirmed that this job works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
