aiguofer commented on code in PR #464:
URL: https://github.com/apache/arrow-java/pull/464#discussion_r1916003045
##########
flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/accessor/impl/calendar/ArrowFlightJdbcTimeStampVectorAccessor.java:
##########
@@ -58,6 +71,7 @@ public ArrowFlightJdbcTimeStampVectorAccessor(
this.holder = new Holder();
this.getter = createGetter(vector);
+ this.isZoned = getVectorIsZoned(vector);
this.timeZone = getTimeZoneForVector(vector);
Review Comment:
Yeah, originally I thought about setting tz to null if not available but
there's some expectations about `timeZone` not being null and having some
default value in a few places where it felt like untangling would make this too
big. I'll add some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
