XiangpengHao commented on code in PR #6961:
URL: https://github.com/apache/arrow-rs/pull/6961#discussion_r1917391222
##########
object_store/src/chunked.rs:
##########
@@ -100,7 +100,7 @@ impl ObjectStore for ChunkedStore {
if exhausted {
return None;
}
- while buffer.len() < chunk_size {
+ while buffer.len() < chunk_size as usize {
Review Comment:
> Given we're buffering these chunks in memory, i wonder if we should keep
usize here
That's a good point, rolled back to use usize instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
