kou commented on code in PR #45274:
URL: https://github.com/apache/arrow/pull/45274#discussion_r1917510095
##########
matlab/src/matlab/+arrow/+io/+ipc/RecordBatchStreamReader.m:
##########
@@ -26,14 +26,34 @@
Schema
end
- methods
- function obj = RecordBatchStreamReader(filename)
Review Comment:
Can we dispatch based on argument automatically instead of providing 2
constructors?
For example:
```matlab
function obj = RecordBatchStreamReader(filename_or_bytes)
if filename_or_bytes.is_a(string)
filename = filename_or_bytes
% ...
else
bytes = filename_or_bytes
% ...
end
end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
