etseidl commented on code in PR #45285:
URL: https://github.com/apache/arrow/pull/45285#discussion_r1918848113


##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1609,6 +1609,9 @@ class TypedColumnWriterImpl : public ColumnWriterImpl, 
public TypedColumnWriter<
 
     auto add_levels = [](std::vector<int64_t>& level_histogram,
                          ::arrow::util::span<const int16_t> levels, int16_t 
max_level) {
+      if (max_level == 0) {

Review Comment:
   minor nit: should this be a constant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to