wuzhoupei commented on PR #45268: URL: https://github.com/apache/arrow/pull/45268#issuecomment-2597339515
I agree some of you. @zanmato1984 But I still think we need to change the task count when task get an error status. Maybe my word in old comment is not exact. The count is the num of running-tasks which I use the 'finished-tasks' in old comment. So this case can be said like that: 1. when the scheduler calling the Abort, if some tasks have started and not finish, this TaskGroup's status will be set as `TaskGroupState::ALL_TASKS_STARTED`. 2. if the running-tasks at above get error, they will not change the num of running-tasks. 3. but the must condition for scheduler calls the AbortFunc is the num of running-tasks is 0. 4. so this case will let the AbortFunc can not be called, and then the ExecPlan will can not call the StopProducingImpl forever(StopProducingImpl will be called in AbortFunc). So I think we should change the count which belongs to scheduler whatever status the task finished with. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
