alamb commented on code in PR #6979: URL: https://github.com/apache/arrow-rs/pull/6979#discussion_r1920807543
########## parquet/src/util/utf8.rs: ########## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! [`check_valid_utf8`] validation function +use crate::errors::{Result, ParquetError}; + +/// Check that `val` is a valid UTF-8 sequence. +/// +/// If the `simdutf8` feature is enabled, this function will use +/// SIMD-accelerated validation from the [`simdutf8`] crate. Otherwise, it will use +/// [`std::str::from_utf8`]. +/// +/// # Errors +/// +/// Returns `Err::General` with a message compatible with [`std::str::from_utf8`] on failure. +/// +/// # Example +/// ``` +/// use parquet::utf8::check_valid_utf8; +/// assert!(check_valid_utf8(b"hello").is_ok()); +/// assert!(check_valid_utf8(b"hello \xF0\x9F\x98\x8E").is_ok()); +/// // invalid UTF-8 +/// assert!(check_valid_utf8(b"hello \xF0\x9F\x98").is_err()); +/// ``` +/// +/// [`simdutf8`]: https://crates.io/crates/simdutf8 +#[inline(always)] +pub fn check_valid_utf8(val: &[u8]) -> Result<()> { Review Comment: It seems reasonable to me -- thank you I looked around in the rest of the parquet code for uses of `std::str::from_utf8` and they seemed somewhat limited (but I could be missing something) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
