lidavidm commented on code in PR #538:
URL: https://github.com/apache/arrow-java/pull/538#discussion_r1921732334
##########
.github/workflows/rc.yml:
##########
Review Comment:
Does this build the docs for the JNI components too? Or do we need to enable
the JNI build to get the Javadocs?
##########
ci/scripts/build.sh:
##########
@@ -61,27 +59,38 @@ done
pushd "${build_dir}"
-if [ "${ARROW_JAVA_SHADE_FLATBUFFERS}" == "ON" ]; then
+# TODO: ARROW_JAVA_SHADE_FLATBUFFERS isn't used for our artifacts. Do
+# we need this?
+# See also: https://github.com/apache/arrow/issues/22021
+if [ "${ARROW_JAVA_SHADE_FLATBUFFERS:-OFF}" == "ON" ]; then
Review Comment:
I think we need to revisit this sometime because of
https://github.com/apache/arrow-java/issues/67 (and it appears Google has
closed the issue asking them to fix it upstream).
AFAIK the discussion in the issue you found is weird...We shouldn't need to
change imports ourselves, the shading should take care of that. But that's not
relevant here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
