pitrou commented on code in PR #45285:
URL: https://github.com/apache/arrow/pull/45285#discussion_r1921913300
##########
cpp/src/parquet/size_statistics_test.cc:
##########
@@ -216,6 +216,20 @@ class SizeStatisticsRoundTripTest : public ::testing::Test
{
}
}
+ void ReadData() {
+ auto reader =
+
ParquetFileReader::Open(std::make_shared<::arrow::io::BufferReader>(buffer_));
+ auto metadata = reader->metadata();
+ for (int i = 0; i < metadata->num_row_groups(); ++i) {
+ int64_t num_rows = metadata->RowGroup(i)->num_rows();
+ auto row_group_reader = reader->RowGroup(i);
+ for (int j = 0; j < metadata->num_columns(); ++j) {
+ auto column_reader = row_group_reader->RecordReader(j);
+ ASSERT_EQ(column_reader->ReadRecords(num_rows), num_rows);
Review Comment:
How about
```suggestion
ASSERT_EQ(column_reader->ReadRecords(num_rows + 1), num_rows);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
