Jefffrey commented on code in PR #6912:
URL: https://github.com/apache/arrow-rs/pull/6912#discussion_r1922041186
##########
arrow-ord/src/rank.rs:
##########
@@ -177,6 +262,51 @@ mod tests {
assert_eq!(res, &[4, 6, 3, 6, 3, 3]);
}
+ #[test]
+ fn test_get_boolean_rank_index() {
+ assert_eq!(get_boolean_rank_index(true, true), 2);
+ assert_eq!(get_boolean_rank_index(false, true), 2);
+ assert_eq!(get_boolean_rank_index(true, false), 1);
+ assert_eq!(get_boolean_rank_index(false, false), 0);
+ }
+
+ #[test]
+ fn test_booleans() {
Review Comment:
These tests are looking good; I think it might be worth adding tests for
BooleanArrays without a null buffer just to cover all the cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
