CurtHagenlocher commented on code in PR #2471:
URL: https://github.com/apache/arrow-adbc/pull/2471#discussion_r1923051953
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -994,7 +1012,7 @@ public override AdbcStatement CreateStatement()
{
if (this.credential == null)
{
- throw new InvalidOperationException();
+ throw new InvalidOperationException("A credential must be
set");
Review Comment:
Should this be an `AdbcException`? We could set the status code to
`AdbcStatusCode.Unauthenticated`.
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -308,11 +316,20 @@ private IArrowArray[] GetCatalogs(
if (catalogs != null)
{
- foreach (CloudProject catalog in catalogs)
+ List<string> projectIds = catalogs.Select(x =>
x.ProjectId).ToList();
+
+ string publicProjectId = "bigquery-public-data";
Review Comment:
consider making const and moving alongside other consts like `infoDriverName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
