protokoul commented on code in PR #45323: URL: https://github.com/apache/arrow/pull/45323#discussion_r1924111204
########## ci/scripts/python_wheel_windows_build.bat: ########## @@ -144,16 +144,13 @@ cp C:\Windows\System32\msvcp140.dll pyarrow\ @REM Since we bundled the Arrow C++ libraries ourselves, we only need to @REM mangle msvcp140.dll so as to avoid ABI issues when msvcp140.dll is @REM required by multiple Python libraries in the same process. -@REM -@REM For now this requires a custom version of delvewheel: -@REM https://github.com/adang1345/delvewheel/pull/59 -%PYTHON_CMD% -m pip install https://github.com/pitrou/delvewheel/archive/refs/heads/fixes-for-arrow.zip || exit /B 1 +%PYTHON_CMD% -m pip install delvewheel || exit /B 1 for /f %%i in ('dir dist\pyarrow-*.whl /B') do (set WHEEL_NAME=%cd%\dist\%%i) || exit /B 1 echo "Wheel name: %WHEEL_NAME%" %PYTHON_CMD% -m delvewheel repair -vv ^ - --mangle-only=msvcp140.dll --no-patch ^ + --ignore-existing --with-mangle=msvcp140.dll ^ Review Comment: I have removed it and pushed latest changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
