alamb commented on a change in pull request #9764:
URL: https://github.com/apache/arrow/pull/9764#discussion_r599589082
##########
File path: rust/arrow/src/ipc/convert.rs
##########
@@ -859,7 +859,7 @@ mod tests {
0, 0,
];
let ipc2 = ipc::root_as_message(&bytes[..]).unwrap();
- let schema2 = ipc.header_as_schema().unwrap();
+ let schema2 = ipc2.header_as_schema().unwrap();
Review comment:
reading the code, it does appear that the intent of this test is to
compare the schema from two different IPC message (aka `schema2` should be
coming from the `ipc2` message) as @gangliao has done here.
The test seems to have failed however
https://github.com/apache/arrow/pull/9764/checks?check_run_id=2161212421
```
thread 'ipc::convert::tests::schema_from_bytes' panicked at 'assertion
failed: `(left == right)`
left: `Schema { endianness: Little, fields: Some([Field { name:
Some("field1"), nullable: false, type_type: Int, type_: Int { bitWidth: 32,
is_signed: false }, dictionary: None, children: Some([]), custom_metadata: None
}]), custom_metadata: None, features: None }`,
right: `Schema { endianness: Little, fields: Some([Field { name:
Some("field1"), nullable: false, type_type: Int, type_: Int { bitWidth: 32,
is_signed: false }, dictionary: None, children: None, custom_metadata: None
}]), custom_metadata: Some([]), features: None }`',
arrow/src/ipc/convert.rs:864:9
```
The difference is that `schema` has `children: Some([])` and `schema2` has
`children: None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
