WillAyd commented on code in PR #45326:
URL: https://github.com/apache/arrow/pull/45326#discussion_r1925697988
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -23,6 +23,12 @@ include(CheckCXXSourceCompiles)
message(STATUS "System processor: ${CMAKE_SYSTEM_PROCESSOR}")
+if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR CMAKE_CXX_COMPILER_ID
STREQUAL "Clang")
Review Comment:
Ah I see what you are saying. I don't know CMake well enough to know if
those labels are always expected to be the same. Happy to make that change.
This originally started by locating the "bug" in SetupCxxFlags.cmake, hence
the condition in the first place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
